bk commit into 5.0 tree (svoj:1.2245)

[Sergey Vojtovich]

Below is the list of changes that have just been committed into a local
5.0 repository of svoj. When svoj does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-08-09 14:33:45+05:00, svoj@stripped +1 -0
  Merge may.pils.ru:/home/svoj/devel/mysql/BUG20060/mysql-4.1
  into  may.pils.ru:/home/svoj/devel/mysql/BUG20060/mysql-5.0
  MERGE: 1.1616.2688.2

  myisam/mi_update.c@stripped, 2006-08-09 14:33:42+05:00, svoj@stripped +0 -0
    Auto merged
    MERGE: 1.15.1.2

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	svoj
# Host:	may.pils.ru
# Root:	/home/svoj/devel/mysql/BUG20060/mysql-5.0/RESYNC

--- 1.21/myisam/mi_update.c	2006-08-09 14:33:52 +05:00
+++ 1.22/myisam/mi_update.c	2006-08-09 14:33:52 +05:00
@@ -172,7 +172,17 @@
   info->update= (HA_STATE_CHANGED | HA_STATE_ROW_CHANGED | HA_STATE_AKTIV |
 		 key_changed);
   myisam_log_record(MI_LOG_UPDATE,info,newrec,info->lastpos,0);
-  VOID(_mi_writeinfo(info,key_changed ?  WRITEINFO_UPDATE_KEYFILE : 0));
+  /*
+    Every myisam function that updates myisam table must end with
+    call to _mi_writeinfo(). If operation (second param of
+    _mi_writeinfo()) is not 0 it sets share->changed to 1, that is
+    flags that data has changed. If operation is 0, this function
+    equals to no-op in this case.
+
+    mi_update() must always pass !0 value as operation, since even if
+    there is no index change there could be data change.
+  */
+  VOID(_mi_writeinfo(info, WRITEINFO_UPDATE_KEYFILE));
   allow_break();				/* Allow SIGHUP & SIGINT */
   if (info->invalidator != 0)
   {