List:Commits« Previous MessageNext Message »
From:Martin Skold Date:August 8 2006 10:22am
Subject:bk commit into 4.1 tree (mskold:1.2499) BUG#18184
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of marty. When marty does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-08-08 12:22:23+02:00, mskold@stripped +3 -0
  bug #18184  SELECT ... FOR UPDATE does not work..: Added lockTuple call in close_scan

  mysql-test/r/ndb_lock.result@stripped, 2006-08-08 12:21:47+02:00, mskold@stripped +12 -3
    bug #18184  SELECT ... FOR UPDATE does not work..: Added lockTuple call in closeScan

  mysql-test/t/ndb_lock.test@stripped, 2006-08-08 12:21:47+02:00, mskold@stripped +13 -2
    bug #18184  SELECT ... FOR UPDATE does not work..: Added lockTuple call in closeScan

  sql/ha_ndbcluster.cc@stripped, 2006-08-08 12:21:45+02:00, mskold@stripped +19 -0
    bug #18184  SELECT ... FOR UPDATE does not work..: Added lockTuple call in closeScan

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	mskold
# Host:	linux.site
# Root:	/home/marty/MySQL/mysql-4.1

--- 1.185/sql/ha_ndbcluster.cc	2006-08-08 12:22:28 +02:00
+++ 1.186/sql/ha_ndbcluster.cc	2006-08-08 12:22:28 +02:00
@@ -2735,6 +2735,25 @@ int ha_ndbcluster::close_scan()
   if (!cursor)
     DBUG_RETURN(1);
 
+  if (m_lock_tuple)
+  {
+    /*
+      Lock level m_lock.type either TL_WRITE_ALLOW_WRITE
+      (SELECT FOR UPDATE) or TL_READ_WITH_SHARED_LOCKS (SELECT
+      LOCK WITH SHARE MODE) and row was not explictly unlocked 
+      with unlock_row() call
+    */
+      NdbOperation *op;
+      // Lock row
+      DBUG_PRINT("info", ("Keeping lock on scanned row"));
+      
+      if (!(op= m_active_cursor->lockTuple()))
+      {
+	m_lock_tuple= false;
+	ERR_RETURN(trans->getNdbError());
+      }
+      m_ops_pending++;      
+  }
   m_lock_tuple= false;
   if (m_ops_pending)
   {

--- 1.8/mysql-test/r/ndb_lock.result	2006-08-08 12:22:28 +02:00
+++ 1.9/mysql-test/r/ndb_lock.result	2006-08-08 12:22:28 +02:00
@@ -64,17 +64,26 @@ pk	u	o
 insert into t1 values (1,1,1);
 drop table t1;
 create table t1 (x integer not null primary key, y varchar(32), z integer, key(z)) engine = ndb;
-insert into t1 values (1,'one',1), (2,'two',2),(3,"three",3);
+insert into t1 values (1,'one',1);
 begin;
 select * from t1 where x = 1 for update;
 x	y	z
 1	one	1
 begin;
-select * from t1 where x = 2 for update;
+select * from t1 where x = 1 for update;
+ERROR HY000: Lock wait timeout exceeded; try restarting transaction
+rollback;
+rollback;
+insert into t1 values (2,'two',2),(3,"three",3);
+begin;
+select * from t1 where x = 1 for update;
 x	y	z
-2	two	2
+1	one	1
 select * from t1 where x = 1 for update;
 ERROR HY000: Lock wait timeout exceeded; try restarting transaction
+select * from t1 where x = 2 for update;
+x	y	z
+2	two	2
 rollback;
 commit;
 begin;

--- 1.10/mysql-test/t/ndb_lock.test	2006-08-08 12:22:28 +02:00
+++ 1.11/mysql-test/t/ndb_lock.test	2006-08-08 12:22:28 +02:00
@@ -73,7 +73,7 @@ drop table t1;
 
 create table t1 (x integer not null primary key, y varchar(32), z integer, key(z)) engine = ndb;
 
-insert into t1 values (1,'one',1), (2,'two',2),(3,"three",3); 
+insert into t1 values (1,'one',1);
 
 # PK access
 connection con1;
@@ -82,9 +82,20 @@ select * from t1 where x = 1 for update;
 
 connection con2;
 begin;
-select * from t1 where x = 2 for update;
 --error 1205
 select * from t1 where x = 1 for update;
+rollback;
+
+connection con1;
+rollback;
+insert into t1 values (2,'two',2),(3,"three",3); 
+begin;
+select * from t1 where x = 1 for update;
+
+connection con2;
+--error 1205
+select * from t1 where x = 1 for update;
+select * from t1 where x = 2 for update;
 rollback;
 
 connection con1;
Thread
bk commit into 4.1 tree (mskold:1.2499) BUG#18184Martin Skold8 Aug