List:Commits« Previous MessageNext Message »
From:Luís Soares Date:February 19 2010 9:44am
Subject:Re: bzr commit into mysql-5.1-bugteam branch (aelkin:3346) Bug#45576
View as plain text  
Hi Andrei,

  Nice Work. Please find my review comments below.

STATUS
------
 
  Approved (see couple of suggestions below).

REQUIRED CHANGES
----------------
 n/a

REQUESTS
--------
 n/a

SUGGESTIONS
-----------
 
  S1. What about replacing the beginning of the test with:

      -- source include/master-slave-reset.inc

      Something like:

=== modified file 'mysql-test/suite/rpl/t/rpl_row_create_table.test'
--- mysql-test/suite/rpl/t/rpl_row_create_table.test	2009-11-27 13:34:39
+0000
+++ mysql-test/suite/rpl/t/rpl_row_create_table.test	2010-02-19 09:39:28
+0000
@@ -136,14 +136,8 @@
 # BUG#22864 (Rollback following CREATE ... SELECT discards 'CREATE
 # table' from log):
 --echo ================ BUG#22864 ================
-connection slave;
-STOP SLAVE;
-RESET SLAVE;
-connection master;
-RESET MASTER;
-connection slave;
-START SLAVE;
-connection master;
+-- source include/master-slave-reset.inc
+-- connection master
 SET AUTOCOMMIT=0;
 CREATE TABLE t1 (a INT);
 INSERT INTO t1 VALUES (1),(2),(3);


      This way we avoid the potential risk of having tables that
      were created in previous tests messing with this one (after
      all this test checks for tables that were not created on
      the slave).

  S2. What about replacing the SELECT I_S with SHOW CREATE TABLE
      for all four tables? This way we keep the test behavior as
      close as we can from original.

DETAILS 
-------
 n/a

On Thu, 2010-02-18 at 18:32 +0000, Andrei Elkin wrote:
> #At file:///home/andrei/MySQL/BZR/FIXES/5.1-bt-bug45576-row_create_table-fails/ based
> on revid:sergey.glukhov@stripped
> 
>  3346 Andrei Elkin	2010-02-18
>       Bug #45576  	rpl_row_create_table fails on PB2
>       
>       The test failed due to Bug #29790.
>       However, logics of the failing part does not need I_S selecting.
>       
>       Fixing to remove the non-deterministic I_S selecting as redundant
>       from a part of the test dealing with BUG@22864.
>      @ mysql-test/suite/rpl/r/rpl_row_create_table.result
>         results updated.
>      @ mysql-test/suite/rpl/t/disabled.def
>         rpl_row_create_table is re-enabled.
>      @ mysql-test/suite/rpl/t/rpl_row_create_table.test
>         removed a non-deterministic I_S selecting as redundant
>         from a part of the test dealing with BUG@22864.
> 
>     modified:
>       mysql-test/suite/rpl/r/rpl_row_create_table.result
>       mysql-test/suite/rpl/t/disabled.def
>       mysql-test/suite/rpl/t/rpl_row_create_table.test
> === modified file 'mysql-test/suite/rpl/r/rpl_row_create_table.result'
> --- a/mysql-test/suite/rpl/r/rpl_row_create_table.result	2009-11-27 13:34:39 +0000
> +++ b/mysql-test/suite/rpl/r/rpl_row_create_table.result	2010-02-18 18:32:50 +0000
> @@ -264,15 +264,6 @@ t1
>  t2
>  t3
>  t4
> -SELECT   TABLE_NAME,ENGINE
> -FROM   INFORMATION_SCHEMA.TABLES
> -WHERE   TABLE_NAME LIKE 't_'
> -ORDER BY TABLE_NAME;
> -TABLE_NAME	ENGINE
> -t1	MyISAM
> -t2	InnoDB
> -t3	InnoDB
> -t4	InnoDB
>  SELECT * FROM t1 ORDER BY a;
>  a
>  1
> @@ -334,15 +325,6 @@ t1
>  t2
>  t3
>  t4
> -SELECT   TABLE_NAME,ENGINE
> -FROM   INFORMATION_SCHEMA.TABLES
> -WHERE   TABLE_NAME LIKE 't_'
> -ORDER BY TABLE_NAME;
> -TABLE_NAME	ENGINE
> -t1	MyISAM
> -t2	InnoDB
> -t3	InnoDB
> -t4	InnoDB
>  SELECT * FROM t1 ORDER BY a;
>  a
>  1
> 
> === modified file 'mysql-test/suite/rpl/t/disabled.def'
> --- a/mysql-test/suite/rpl/t/disabled.def	2009-12-01 09:21:15 +0000
> +++ b/mysql-test/suite/rpl/t/disabled.def	2010-02-18 18:32:50 +0000
> @@ -9,5 +9,3 @@
>  #  Do not use any TAB characters for whitespace.
>  #
>  ##############################################################################
> -
> -rpl_row_create_table    : Bug#45576 2009-12-01 joro rpl_row_create_table fails on
> PB2
> 
> === modified file 'mysql-test/suite/rpl/t/rpl_row_create_table.test'
> --- a/mysql-test/suite/rpl/t/rpl_row_create_table.test	2009-11-27 13:34:39 +0000
> +++ b/mysql-test/suite/rpl/t/rpl_row_create_table.test	2010-02-18 18:32:50 +0000
> @@ -160,10 +160,6 @@ INSERT INTO t1 VALUES (4),(5),(6);
>  ROLLBACK;
>  
>  SHOW TABLES;
> -SELECT   TABLE_NAME,ENGINE
> -  FROM   INFORMATION_SCHEMA.TABLES
> - WHERE   TABLE_NAME LIKE 't_'
> -ORDER BY TABLE_NAME;
>  SELECT * FROM t1 ORDER BY a;
>  SELECT * FROM t2 ORDER BY a;
>  SELECT * FROM t3 ORDER BY a;
> @@ -173,10 +169,6 @@ SELECT * FROM t4 ORDER BY a;
>  SHOW BINLOG EVENTS FROM 106;
>  sync_slave_with_master;
>  SHOW TABLES;
> -SELECT   TABLE_NAME,ENGINE
> -  FROM   INFORMATION_SCHEMA.TABLES
> - WHERE   TABLE_NAME LIKE 't_'
> -ORDER BY TABLE_NAME;
>  SELECT * FROM t1 ORDER BY a;
>  SELECT * FROM t2 ORDER BY a;
>  SELECT * FROM t3 ORDER BY a;
> 


Thread
bzr commit into mysql-5.1-bugteam branch (aelkin:3346) Bug#45576Andrei Elkin18 Feb
  • Re: bzr commit into mysql-5.1-bugteam branch (aelkin:3346) Bug#45576Luís Soares19 Feb