List:Backup« Previous MessageNext Message »
From:Ingo Strüwing Date:January 12 2010 9:44am
Subject:DBUG and DEBUG_SYNC are independent
View as plain text  
Hi Rafal,

In 6.0 I found:

#ifndef DBUG_OFF
  if (lex->sql_command != SQLCOM_SET_OPTION)
    DEBUG_SYNC(thd,"before_execute_sql_command");
#endif

Hi Chuck,

In 5.6 I found

#ifndef DBUG_OFF
//  if (lex->sql_command != SQLCOM_SET_OPTION)
//    DEBUG_SYNC(thd,"before_execute_sql_command");
#endif

Hi all,

DEBUG_SYNC and DBUG are independent. In default builds they are enabled
or disabled together, but they can be enabled/disabled independently. If
we include DEBUG_SYNC in #ifndef DBUG_OFF, the sync point would not
exist in non-dbug builds with enabled Debug Sync Facility. Some tests
may stall due to the missing sync point. So please use

#if defined(ENABLED_DEBUG_SYNC)

in such cases. An alternative could be:

  DEBUG_SYNC(thd, (lex->sql_command != SQLCOM_SET_OPTION) ?
             "before_execute_sql_command" : "");

Why has this been commented out in 5.6? The sync point
"before_execute_sql_command" is used in backup_bml_not_falcon and
backup_bml. Both are marked as "hang" or "timeout" in the backport test
failures table.

Regards
Ingo
-- 
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder,   Wolfgang Engels,   Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring   HRB München 161028
Thread
DBUG and DEBUG_SYNC are independentIngo Strüwing12 Jan
  • Re: DBUG and DEBUG_SYNC are independentRafal Somla12 Jan
    • Re: DBUG and DEBUG_SYNC are independentIngo Strüwing14 Jan
  • Re: DBUG and DEBUG_SYNC are independentIngo Strüwing13 Jan